Conversation
There was a problem hiding this comment.
Impressive! Ran fine in Rstudio cloud. I did not yet go through your code.
- Change "Show XX entries" 100 is maximum in the drop-down. Change to 50 ? because actual limit is 50
- On my screen, there is large left margin. Possible to remove?
- Introductory text is fine.
- Just nitpicking here:
- "preview of the datasets" change to "preview of all datasets"
- Text is all black and white; no indication user should click.
- Several datasets are less than 50. Maybe I could add the number of rows, like
- ce_vaccine (44): Clinical Events for Vaccine
Will go through your code now.
jimrothstein
left a comment
There was a problem hiding this comment.
Code flows nicely - easy to follow.
- need library() for DT, rlang?
- I probably would have attempted either shiny or Github actions to create html.
😄
|
Nice suggestions, I agree with all. And to respond your questions:
Good point. Needs to be added in DESCRIPTION
In principle this should already align with the GitHub action they already have in place (unless I missed something!) Do you want me to start making these changes or you take care of it @jimrothstein ? |
|
@Gero1999 |
|
@jimrothstein @Gero1999, The draft looks great! One suggestion is to categorize the |
That is a great idea! I will use the specs yaml file instead then |
|
I investigated a bit and for static pages seems to be better On the other hand, @jimrothstein I am not needing Also if you feel everything is ready perhaps we can open the PR and ask for additional reviews |
|
@Gero1999 Starts to render as html, but stops at first chunk (echo = FALSE); no error. |
there is some issue, check below error
|
|
hopefully now is fixed! otherwise I will give it a deeper look later |
Looks good now. Just make sure the therapeutic area sorting order is maintained. |
The plan was to issue an ad‑hoc release in the spring to include the microbiology data, the new vignette will therefore be available at that time as well. |
if the package isn't changing, you could delete the release and do a "new release" with the vignette and that will trigger the build of website with the vignette. be so cool to have it out before spring time! it is such a neat addition. |
Co-authored-by: Fanny Gautier <157114584+Fanny-Gautier@users.noreply.github.com>
|
As requested by @Fanny-Gautier I applied the suggestions and I also made other table display changes to improve readability Regarding this:
The thing is that we cannot make sure this link works until we merge and deploy the page (I am using the link is supposed to hold the website page). Perhaps is cleaner if we open a different PR after merging this one in order to do this. Or we can keep what it is and correct after merging otherwise. I leave it to your criteria Hopefully I did not miss anything, but please feel free to point out any potential improvement or missing aspect! |
There was a problem hiding this comment.
Minor comments to implement, plus please tick all the boxes in the checklist, and I believe it will be ready to go!
The link issue on the main page will be resolved once the PR is merged into main and the updated website is available online.
Thank you for providing such an amazing vignette!
NEWS.md
Outdated
|
|
||
| - The reference page has been updated to categorize datasets by therapeutic areas. (#204) | ||
|
|
||
|
|
Fanny-Gautier
left a comment
There was a problem hiding this comment.
Sorting order to implement and it will be ready to go! Great job here too, Thank you @Gero1999 !
Fanny-Gautier
left a comment
There was a problem hiding this comment.
Perfect! Thank you!
|
Thanks for the reviews @Fanny-Gautier @Lina2689, I am not allowed to merge but feel free to do so if you feel is ready to go!
|
|
@manciniedoardo Could you please approve the PR? I’ll merge it right after approval. |










Implementation description
This PR:
preview-sdtm.Rmd, which provides an interactive, filterable preview of all datasets in thepharmaversesdtmpackage, displaying the first 50 rows of each dataset in collapsible panels using DT package._pkgdown.ymlto add a "Preview SDTM" link in the navbar, pointing to the new vignette.styler::style_file()to style R and Rmd filesdevtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdif the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers)pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()