Skip to content

Vectorize colwidths#63

Open
eanokian wants to merge 11 commits intopharmaverse:mainfrom
eanokian:vectorize_colwidths
Open

Vectorize colwidths#63
eanokian wants to merge 11 commits intopharmaverse:mainfrom
eanokian:vectorize_colwidths

Conversation

@eanokian
Copy link
Copy Markdown

updated gentlg() to accept argument wcol as a list of vectors, which allows to apply different column widths for each element in huxme (when huxme is a list of dataframes).

Copy link
Copy Markdown

@gmbecker gmbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor tweaks but looks good

Copy link
Copy Markdown

@gmbecker gmbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few final tweaks and additional comments. After these consider it approved

eanokian

This comment was marked as outdated.

eanokian and others added 2 commits March 24, 2026 10:17
Co-authored-by: Gabe Becker <gabembecker@gmail.com>
Co-authored-by: Gabe Becker <gabembecker@gmail.com>
@eanokian
Copy link
Copy Markdown
Author

thanks @gmbecker for the feedback, they make sense and applied the suggested changes. There's just a comment I left regarding a check that is being performed in gentlg_single() as well, just waiting for your stand on whether I should remove it from gentlg().

R/gentlg.R Outdated
"vector, otherwise pass a non-data.frame list to 'huxme'."
)
}
## already know wcol is a list and huxme is a non-data.frame list
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what a non-data.frame list is.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's related to @gmbecker 's comment, a single data.frame is also a list:

> is.list(mtcars)
[1] TRUE

a "non-data.frame list" is a list that also is not a single data.frame. E.g.
list(mtcars) is a non-data.frame list, but mtcars is not.

@eanokian eanokian requested a review from kpagacz March 25, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants