Open
Conversation
1 task
gmbecker
reviewed
Mar 16, 2026
gmbecker
reviewed
Mar 16, 2026
gmbecker
reviewed
Mar 16, 2026
gmbecker
approved these changes
Mar 16, 2026
gmbecker
left a comment
There was a problem hiding this comment.
few final tweaks and additional comments. After these consider it approved
Co-authored-by: Gabe Becker <gabembecker@gmail.com>
Co-authored-by: Gabe Becker <gabembecker@gmail.com>
eanokian
commented
Mar 24, 2026
Author
|
thanks @gmbecker for the feedback, they make sense and applied the suggested changes. There's just a comment I left regarding a check that is being performed in |
kpagacz
requested changes
Mar 24, 2026
R/gentlg.R
Outdated
| "vector, otherwise pass a non-data.frame list to 'huxme'." | ||
| ) | ||
| } | ||
| ## already know wcol is a list and huxme is a non-data.frame list |
Collaborator
There was a problem hiding this comment.
I don't understand what a non-data.frame list is.
Author
There was a problem hiding this comment.
it's related to @gmbecker 's comment, a single data.frame is also a list:
> is.list(mtcars)
[1] TRUE
a "non-data.frame list" is a list that also is not a single data.frame. E.g.
list(mtcars) is a non-data.frame list, but mtcars is not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated
gentlg()to accept argument wcol as a list of vectors, which allows to apply different column widths for each element in huxme (when huxme is a list of dataframes).