Fixes #2 , #3 , #4 , #6 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ducasse Could you please review this PR |
|
Thanks I will have a look I hope later today. |
|
Sounds good to me. Tx for the contribution. |
|
@AhmedHamdiy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
CTQueueclass and its associated test class,CTQueueTest. The primary focus is on enhancing the functionality of the queue and improving the test coverage to ensure the correctness of the queue operations.Enhancements to
CTQueueclass:remove,removeIfNone,poll,peek, andsizeto handle various queue operations more effectively.Improvements to
CTQueueTestclass:testAddGarantyFIFOOrderto ensure elements are dequeued in FIFO order and added an assertion to check if the queue is empty.testAddAll,testEmptyQueueRemove,testIsEmpty,testPeek,testPoll,testRemove, andtestRemoveIfNoneto cover additional scenarios and ensure the robustness of the queue operations.