Skip to content

Revert "Editable inspector values" #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Revert "Editable inspector values" #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions src/NewTools-Inspector/StRawInspectionPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,26 +171,15 @@ StRawInspectionPresenter >> step [
attributeTable updateRootsKeepingSelection: rootNodes
]

{ #category : 'building' }
StRawInspectionPresenter >> updatePresenterTitle [
"Callback after changing a receiver's value (in a column for an instance variable). Update the window title and its header to display the new value"
| wp |

wp := self window presenter.
wp firstPage updateHeaderBar.
self window title: wp windowTitle
]

{ #category : 'building' }
StRawInspectionPresenter >> valuesColumn [

^ SpStringTableColumn new
title: 'Value';
evaluated: #stringValue;
beEditable;
"beEditable;"
onAcceptEdition: [ :node :value |
self write: node value: value.
self updatePresenterTitle ];
self inform: node label , '=' , value asString "node value: value" ];
sortFunction: #stringValue ascending;
yourself
]
Expand All @@ -211,13 +200,3 @@ StRawInspectionPresenter >> variablesColumn [
sortFunction: #label ascending;
yourself
]

{ #category : 'writing' }
StRawInspectionPresenter >> write: aStInspectorSlotNode value: aString [
"Update the value of aStInspectorSlotNode with new value aString.
Convert aString to the 'native' object parsing it as number or using parseLiterals (for booleans or strings)"

aStInspectorSlotNode slot
write: (NumberParser parse: aString onError: [ aString parseLiterals first ])
to: aStInspectorSlotNode hostObject
]