Add bid validation module with EUPHEMIA compliance checks#7
Merged
Conversation
Adds a comprehensive validation layer covering EUPHEMIA rules (max curve steps, block duration limits), data quality (minimum volumes, price increments), temporal constraints (gate closure, delivery periods), and portfolio-level sanity checks. Exports all validation functions and exception types from the top-level package and documents usage in the README. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@claude can you improve the code coverage for the 7 lines missing in validation.py? |
|
Claude finished @tommed's task in 5m 14s —— View job Improving code coverage for
|
- validate_price_step_increments: single-step curve early return - validate_delivery_within_day: naive auction_day raises ValueError - validate_mtu_within_day: naive auction_day raises ValueError - validate_exclusive_group_volumes: single-bid group early return (via model_construct) - validate_bid: dispatch to validate_linked_block_bid - validate_bid: dispatch to validate_exclusive_group_bid - validate_order_book_for_submission: defaults submission_time to datetime.now(UTC) Co-authored-by: Tom Medhurst <tommed@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validation.pywith comprehensive EUPHEMIA-compliance checks, data quality validation, temporal constraint enforcement, and portfolio-level sanity checksValidationError,EuphemiaValidationError,DataQualityError,TemporalValidationError,PortfolioValidationError) from the top-level packageTest plan
make test)mypy src— no issuesruff check src tests— all checks passed🤖 Generated with Claude Code