Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
phbnf
force-pushed
the
newspecs
branch
3 times, most recently
from
July 22, 2026 17:53
e171d7a to
24cadc6
Compare
phbnf
force-pushed
the
newspecs
branch
2 times, most recently
from
July 23, 2026 10:56
895d522 to
3597cbb
Compare
Replace the wrapper around invalidConsistencyProof with a dedicated invalidSubtreeConsistencyProof function in cmd/proofgen/main.go. TAG=agy CONV=1f76bf92-7d8b-43a5-942a-a4bd88025626
Update FindSubtrees in proof/proof.go to return two Subtree structs by value instead of allocating a []Subtree slice. TAG=agy CONV=1f76bf92-7d8b-43a5-942a-a4bd88025626
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was <= 1.
(
[][]byte{}) whenstart == end.* Proof Verification: Updated
VerifySubtreeConsistencyin verify.go to checkif start == endupfront, verifyingend <= size,len(proof) == 0, andsubRoot == hasher.EmptyRoot()withoutduplicate subtree validity calls or comparing against
parentRoot. UpdatedRootFromSubtreeConsistencyProofto returnhasher.EmptyRoot()whenstart == end && size == 0.* Reference Implementation: Clarified preconditions in
refSubtreeConsistencyProofin reference_test.go to explicitly handlestart == endreturningnil(empty proof).* Tests & Vectors: Updated test loop bounds across proof_test.go, tree_test.go, and vectors_test.go to use inclusive upper limits (
range ... + 1) to cover right edges and empty subtrees. Updatedrolling SHA-256 test digests to match PR #275.
* Probe Generator: Added static test vectors for empty subtrees in main.go and updated generated JSON testdata in
testdata/subtreeconsistency/.