This repository was archived by the owner on Oct 15, 2023. It is now read-only.
[SlashTags] Fix buttons when skipped dynamically#122
Open
npc203 wants to merge 1 commit intophenom4n4n:masterfrom
Open
[SlashTags] Fix buttons when skipped dynamically#122npc203 wants to merge 1 commit intophenom4n4n:masterfrom
npc203 wants to merge 1 commit intophenom4n4n:masterfrom
Conversation
phenom4n4n
suggested changes
Feb 14, 2022
Owner
There was a problem hiding this comment.
This makes it so that buttons that aren't supposed to be able to be used error with "This interaction failed". Instead of not having buttons respond, prevent them from being used in ButtonMenuMixin._get_components, either by disabling them if they fail the skip_if check or not adding them to the component list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix on slashtags, An edge can when "calling" the button could return a None object.
Reference: link
Added an extra check to just prematurely close the function.