Fix backward navigation to wrap around to last item#25
Merged
Conversation
When pressing 'k' with no bookmark selected, start from the last item instead of the first. This applies to all views: bookmarks, tags, read later, and inbox. https://claude.ai/code/session_01S1ZzZyJ7qKkPzkwsQhEYsz
✅ Deploy Preview for hypermarkk ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed backward navigation (previous item) in bookmark lists to properly wrap around to the last item when at the beginning, and handle empty lists correctly.
Key Changes
BookmarkList.jsx: Updated
selectPrevcallback to wrap navigation from index 0 to the last item in the filtered listfilteredBookmarks.lengthto ensure callback updates when list changesInboxView.jsx: Applied identical fix to
selectPrevcallback for consistencybookmarks.lengthto ensure callback updates when list changesImplementation Details
The changes enable circular navigation where pressing "previous" at the start of a list wraps to the end, improving UX for keyboard navigation. Both components now handle edge cases consistently:
https://claude.ai/code/session_01S1ZzZyJ7qKkPzkwsQhEYsz