Fix LocalHints.getElementFromPoint for shadow roots containing only text #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LocalHints.getElementFromPointcould return nothing if it's called on a shadow root element which only contains some text (no additional tags), sinceelementsFromPointcan return an empty array if there's no element (e.g. only a text node) to return. This causes a problem where the link-hint for a clickable element containing such a shadow root could be mistakenly hidden.In this case, we can't produce an element to represent the content of the shadow root (because it contains no elements!), so we should just return the shadow root itself.
Should fix #4620.