This repository was archived by the owner on May 20, 2025. It is now read-only.
Fix issue 17 compatibility with metalsmith watch#23
Open
manticorps wants to merge 2 commits intophildotdev:masterfrom
manticorps:fix-issue-17-compatibility-with-metalsmith-watch
Open
Fix issue 17 compatibility with metalsmith watch#23manticorps wants to merge 2 commits intophildotdev:masterfrom manticorps:fix-issue-17-compatibility-with-metalsmith-watch
manticorps wants to merge 2 commits intophildotdev:masterfrom
manticorps:fix-issue-17-compatibility-with-metalsmith-watch
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The main problem is the watch (and other metalsmith auto-reload plugin) doesn't cleanup the metadata between run.
To avoid that, I just avoid to return an error in dev-mode. I am not entirely happy with this workaround, but this is working.
An another solution can be to keep in the metadata all the files already parsed, but this can be a problem on large project with tons of files.
p.s. this is my first contribution in github, if I have done some mistake like how to link with the issue be free to tell me.