chore: fix acceptance tests on default branch#824
Merged
Ron (rjaegers) merged 28 commits intomainfrom Jun 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes acceptance tests on the default branch by adjusting how the IMAGE_VERSION secret is set, and corrects a minor grammar issue in the README.
- Corrected phrasing in the release notes description in README.md
- Added a conditional in the workflow to set
IMAGE_VERSIONsecret differently for PR builds versus the default branch
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updated “that included” to “that include” for present-tense accuracy |
| .github/workflows/wc-acceptance-test.yml | Wrapped gh secret set calls in an if/else to handle PR vs edge |
Comments suppressed due to low confidence (2)
.github/workflows/wc-acceptance-test.yml:33
- The indentation of this
ifblock is inconsistent with the surrounding script lines and may break execution. Align it to the same level asset -Eeuo pipefail.
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
.github/workflows/wc-acceptance-test.yml:34
- [nitpick] For clarity, consider using the long-form flag
--app codespacesinstead of the short-a codespacesin thegh secret setcommand.
gh secret set -a codespaces IMAGE_VERSION --body "pr-${{ github.event.pull_request.number }}"
Contributor
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
Contributor
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports
|
Contributor
EkelmansPh
approved these changes
Jun 17, 2025
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
…s://github.com/philips-software/amp-devcontainer into feature/fix-acceptance-tests-on-default-branch
|
Ron (rjaegers)
deleted the
feature/fix-acceptance-tests-on-default-branch
branch
Contributor
Pull Request Report (#824)Static measures
Time related measures
Status check related measures
|
Contributor
|
🎉 Hooray! The changes in this pull request went live with the release of v6.1.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
This PR fixes the acceptance tests for non-PR branches and fix the annotations on the main image.
✔️ Checklist