feat: remove docker cli from amp-devcontainer-cpp#832
Merged
Ron (rjaegers) merged 3 commits intomainfrom Jun 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Docker CLI integration throughout the project.
- Removes the integration test that verifies Docker CLI access.
- Removes Docker socket mounting from both Rust and C++ devcontainer configurations.
- Removes Docker CLI installation steps and related build arguments in the C++ Dockerfile.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/cpp/integration-tests.bats | Removed test for Docker CLI functionality |
| .devcontainer/rust/devcontainer.json | Removed Docker socket mount configuration |
| .devcontainer/cpp/devcontainer.json | Removed Docker socket mount configuration |
| .devcontainer/cpp/Dockerfile | Removed Docker CLI installation block and related build argument |
Comments suppressed due to low confidence (3)
test/cpp/integration-tests.bats:190
- The removal of the Docker CLI integration test is consistent with the PR’s objectives. Please ensure that any related documentation or comments are updated to reflect this change.
assert_output "Hello World!"
.devcontainer/rust/devcontainer.json:8
- The Docker socket mount has been removed from the Rust devcontainer configuration as expected. Verify that no development workflows depend on having Docker access from within the container.
"CONTAINER_FLAVOR": "rust"
.devcontainer/cpp/Dockerfile:58
- The Docker CLI installation block has been removed correctly; please confirm that there are no downstream dependencies that might require the Docker CLI to be present.
ENV PATH="$PATH:/opt/gcc-arm-none-eabi/bin"
Ron (rjaegers)
changed the title
Contributor
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
Contributor
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 18 | 0 | 0 | 0.48s | |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.89s | |
| ✅ GHERKIN | gherkin-lint | 2 | 0 | 0 | 0.99s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.44s | |
| ✅ JSON | prettier | 16 | 1 | 0 | 0 | 0.44s |
| ✅ JSON | v8r | 16 | 0 | 0 | 8.01s | |
| ✅ MARKDOWN | markdownlint | 9 | 0 | 0 | 0 | 0.93s |
| ✅ MARKDOWN | markdown-table-formatter | 9 | 0 | 0 | 0 | 0.21s |
| ✅ REPOSITORY | checkov | yes | no | no | 17.73s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.41s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| grype | yes | no | 2 | 23.59s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 0.99s | |
| ✅ REPOSITORY | syft | yes | no | no | 2.0s | |
| ✅ REPOSITORY | trivy | yes | no | no | 6.25s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.23s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 3.07s | |
| ✅ SPELL | lychee | 63 | 0 | 0 | 21.81s | |
| ✅ YAML | prettier | 24 | 0 | 0 | 0 | 0.86s |
| ✅ YAML | v8r | 24 | 0 | 0 | 7.19s | |
| ✅ YAML | yamllint | 24 | 0 | 0 | 0.73s |
See detailed report in MegaLinter reports
Contributor
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
Contributor
Test Results 4 files ±0 4 suites ±0 2m 22s ⏱️ -4s Results for commit 40fd228. ± Comparison against base commit fcc3527. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
EkelmansPh
approved these changes
Jun 24, 2025
|
Contributor
Pull Request Report (#832)Static measures
Time related measures
Status check related measures
|
Contributor
|
🎉 Hooray! The changes in this pull request went live with the release of v6.2.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
As was mentioned in the release notes of version 6.1.0 the docker cli is removed from amp-devcontainer-cpp.
✔️ Checklist