Skip to content

feat: add meta proto service for service discovery #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

feat: add meta proto service for service discovery #543

wants to merge 73 commits into from

Conversation

oguzcanoguz
Copy link
Contributor

No description provided.

@oguzcanoguz oguzcanoguz requested a review from a team as a code owner January 25, 2024 14:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 12 0 0.05s
✅ CPP clang-format 1015 4 0 6.96s
✅ DOCKERFILE hadolint 2 0 0.14s
✅ JSON jsonlint 7 0 0.18s
✅ JSON prettier 7 0 0 0.66s
⚠️ MARKDOWN markdownlint 6 0 4 1.24s
⚠️ MARKDOWN markdown-link-check 6 1 47.56s
✅ MARKDOWN markdown-table-formatter 6 0 0 0.22s
✅ REPOSITORY checkov yes no 20.29s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY grype yes no 11.25s
✅ REPOSITORY ls-lint yes no 0.07s
✅ REPOSITORY secretlint yes no 6.3s
✅ REPOSITORY trivy yes no 7.05s
✅ REPOSITORY trivy-sbom yes no 0.09s
✅ REPOSITORY trufflehog yes no 3.46s
⚠️ SPELL lychee 140 1 4.16s
⚠️ YAML prettier 22 1 1 1.2s
✅ YAML v8r 22 0 10.0s
✅ YAML yamllint 22 0 0.43s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

github-actions[bot]
github-actions bot reviewed Jan 25, 2024
View reviewed changes
oguzcanoguz and others added 9 commits January 25, 2024 15:55
@oguzcanoguz @github-actions
Update protobuf/meta_services/ServiceDiscoveryEcho.cpp
cdc8fb3 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz @github-actions
Update protobuf/meta_services/ServiceDiscoveryEcho.cpp
adb0092 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz @github-actions
Update protobuf/meta_services/ServiceDiscoveryEcho.cpp
f15b249 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz @github-actions
Update protobuf/meta_services/test/TestServiceDiscoveryEcho.cpp
d5d9dc2 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz @github-actions
Update protobuf/meta_services/test/TestServiceDiscoveryEcho.cpp
cf77db0 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz @github-actions
Update protobuf/meta_services/ServiceDiscoveryEcho.cpp
9622fe2 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz @github-actions
Update protobuf/meta_services/ServiceDiscoveryEcho.cpp
b6cc192 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz @github-actions
Update protobuf/meta_services/test/TestServiceDiscoveryEcho.cpp
bbc7075 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz @github-actions
Apply suggestions from code review
b9239e9 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz oguzcanoguz reopened this Jan 26, 2024
@oguzcanoguz oguzcanoguz marked this pull request as draft January 26, 2024 14:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@richardapeters richardapeters changed the title feat: Add meta proto service for service discovery feat: add meta proto service for service discovery Feb 21, 2024
github-actions[bot]
github-actions bot reviewed Apr 26, 2024
View reviewed changes
oguzcanoguz and others added 28 commits December 17, 2024 21:22
@oguzcanoguz
Fix lots of stuff to make EchoConsole to discover services of RefProd
5410260 
This commit misses many unit tests!
@oguzcanoguz
Remove temporary tracing
8052a28
@oguzcanoguz
Merge branch 'main' into feature/proto_service_discovery
9f9594a
@oguzcanoguz
Make ServiceForwarderAll use a reserved svc id and assert this stays …
1194ba5 
…reserved
@oguzcanoguz
Fix the existing ServiceDiscovery tests, more tests need to be added
fd44ae0
@oguzcanoguz
ServiceDiscoveryEcho clean
d6d4b06
@oguzcanoguz
TestServiceDiscoveryEcho: Add test for clashing responses
8324508
@oguzcanoguz
Clean up echo_console a bit
10f3094
@oguzcanoguz
Make ConsoleService a library to unit test
8a4b938
@oguzcanoguz
Small refactor on TestConsoleService
48c20df
@oguzcanoguz
fix echo_console_test build
20576e8
@oguzcanoguz
add first unit test for console_service
9e65474
@oguzcanoguz
modify consoleservice test, does not work yet
8742853
@oguzcanoguz
TestConsoleService first test passing
ca225a9
@oguzcanoguz
Fix echo console build (not tested if it still works)
798e39d
@oguzcanoguz
minor refactor TestConsoleService
7fe829e
@oguzcanoguz
ConsoleServiceProxy tests are passing
12e26ea
@oguzcanoguz
Implement EchoConsoleService
b529fc4
@oguzcanoguz
Merge branch 'main' into feature/proto_service_discovery
c942ad1
@oguzcanoguz
Merge remote-tracking branch 'origin/main' into feature/proto_service…
ce76d1e 
…_discovery
@oguzcanoguz
Fix not calling service done in EchoConsoleService
342aecf
@oguzcanoguz
Remove commented out code
0dcb1d4
@oguzcanoguz
Remove Echo test server, can now use refprod
2195a41
@oguzcanoguz @github-actions
Update protobuf/meta_services/PeerServiceDiscoverer.hpp
c8fa558 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz @github-actions
Update protobuf/meta_services/PeerServiceDiscoverer.cpp
2430613 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz @github-actions
Apply suggestions from code review
b2a1636 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oguzcanoguz
Merge branch 'main' into feature/proto_service_discovery
9b72b3b
@oguzcanoguz
Clean up includes
1f3f33b
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@oguzcanoguz oguzcanoguz marked this pull request as ready for review April 17, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@richardapeters richardapeters Awaiting requested review from richardapeters

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oguzcanoguz