refactor: remove asciidoctor-plantuml extension support#44
Open
Baris Tanyeri (BarisTanyeri) wants to merge 2 commits intomainfrom
Open
refactor: remove asciidoctor-plantuml extension support#44Baris Tanyeri (BarisTanyeri) wants to merge 2 commits intomainfrom
Baris Tanyeri (BarisTanyeri) wants to merge 2 commits intomainfrom
Conversation
…cumentation for Kroki integration
Copilot started reviewing on behalf of
Baris Tanyeri (BarisTanyeri)
April 10, 2026 16:12
View session
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated asciidoctor-plantuml plugin/server wiring from the Antora site generation action, leaving Kroki (and Mermaid via Kroki) as the supported diagram-rendering path.
Changes:
- Remove
asciidoctor-plantumlfrom documented supported rendering plugins and from the Docker image global npm installs. - Stop passing
plantuml-server-urlinto the Antora invocation. - Remove the PlantUML server container and related dependencies/env vars from the Docker Compose setup and composite action step.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates documentation to reflect only asciidoctor-kroki as the supported rendering plugin. |
| entrypoint.sh | Removes the plantuml-server-url attribute from the Antora CLI invocation. |
| Dockerfile | Drops the global install of asciidoctor-plantuml; keeps Kroki + Lunr extension. |
| docker-compose.yml | Removes the PlantUML service and its dependency/env wiring; keeps Kroki + Mermaid. |
| action.yml | Updates action description/step and Compose startup to no longer include PlantUML. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes deprecated asciidoctor-plantuml plugin support.