Add GitHub Actions workflow to build site on PRs#74
Open
etagwerker wants to merge 3 commits into
Open
Conversation
Runs `bundle exec middleman build` on every PR to main and on pushes to main, so dependency bumps (Dependabot) and other changes can be verified automatically instead of relying on a human running the build locally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions CI workflow to build the Middleman site for pull requests and pushes to main, to catch build regressions automatically (including in dependency update PRs).
Changes:
- Introduces a new
Buildworkflow triggered onpull_requestandpushevents formain. - Checks out the repo, sets up Ruby with Bundler caching, and runs
bundle exec middleman build.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
`make build` depends on `make deps`, which runs `npm install` and fails because `karma-phantomjs-launcher` pulls in PhantomJS — its install script no longer works on modern Node. The JS toolchain (karma, phantomjs, bower) is only used for the karma test suite, not for building the static site, so CI can skip it entirely. The Makefile remains untouched for local dev. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/build.ymlthat runsbundle exec middleman buildon every PR tomainand on pushes tomain.ruby/setup-ruby@v1withbundler-cache: true, so Ruby version is picked up from.ruby-version(3.4.2) and gems are cached between runs.Why
Right now every merge (especially Dependabot bumps like #68, #70–#72) relies on a human running the build locally to confirm nothing broke. A simple CI build catches regressions automatically and lets us trust Dependabot PRs at a glance.
Test plan
mainafter merge also goes green🤖 Generated with Claude Code