Implement dehumidifier#7
Open
filmackay wants to merge 1 commit into
Open
Conversation
Author
|
I am finding the humidity numbers are non-sensical when, the fan is not running. Temperature seems reasonable. I am thinking of making the humidity publish as Thoughts/feedback? |
|
confirming this fixed my issues |
Author
|
Any thoughts @philm5? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for De'Longhi Dehumidifiers. The changes separate device handling by type (air conditioner, heater, dehumidifier), add new platforms for dehumidifier support, and improve code clarity and maintainability. Additionally, the documentation is enhanced with a comprehensive overview, and configuration and polling intervals are refined.
Device architecture and coordinator routing:
__init__.pyto sort discovered devices into separate coordinator lists by type (airconditioner_coordinators,heater_coordinators,dehumidifier_coordinators). All platform files now use these lists, improving clarity and making it easier to add device-specific logic. [1] [2] [3] [4] [5] [6]Dehumidifier support:
humidifier.pyplatform for dehumidifier entities, implementing theDeLonghiDehumidifierclass with support for on/off, mode, and humidity setpoint, and exposing a device mode mapping for use in other platforms.binary_sensor.pyplatform for dehumidifier alarm states (tank full, filter warning), using bitmask extraction from the device'salarm_stateproperty.select.pyplatform with aDehumidifierModeSelectentity for changing dehumidifier modes, using the shared device mode mapping. [1] [2]sensor.pyto add dehumidifier-specific sensors using a new set of entity descriptions.Configuration and constants:
OEM_MODEL_HEATER,OEM_MODEL_DEHUMIDIFIER) and updated code to use these for device type checks.Documentation and developer experience:
OVERVIEW.mddescribing the integration's purpose, architecture, complexity, and key files, aiding onboarding and maintenance.Other improvements and fixes:
config_flow.pyrelated to options flow initialization. [1] [2]Resolves #2.