Skip to content

Energy transfer for contact binaries#1077

Open
matthiasfabry wants to merge 100 commits into
feature-contactsfrom
longitude-dependence
Open

Energy transfer for contact binaries#1077
matthiasfabry wants to merge 100 commits into
feature-contactsfrom
longitude-dependence

Conversation

@matthiasfabry

@matthiasfabry matthiasfabry commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator

Implements parametric contact-binary energy transfer.
4 schemes are currently supported:

  1. Simple smoothing of the neck temperatures to avoid discontinuities (implemented by @aprsa, @gecheline)
  2. Isotropic mixing where the temperatures depend on the distance to the neck (also implemented by @aprsa, @gecheline)
  3. lateral mixing on a horizontal band (designed by @aprsa and @gecheline, improved by me)
  4. Perfect mixing, setting temperatures to that of the primary

kecnry and others added 30 commits October 4, 2024 11:14
@kecnry
hacky support for contact temperature smoothing
b4786d5
@gecheline @kecnry
added .save_as_standard_mesh after smoothing
f0fe605
@kecnry
cache "smoothed_teffs"
4720723
@gecheline @kecnry
update weighing to use highest teff2 instead of teff1_neck
a9c363f
@kecnry
added lateral, isotropic and spotty mixing
7e429c7
@gecheline @kecnry
parameterization of mixing methods with user-provided power and fixed…
0bc0a0c 
… teffratio from bundle
@gecheline @kecnry
updated limits for mixing power to None
37a007d
@aprsa @kecnry
Added "spotted" option to mixing_method.
1530d58
@aprsa @kecnry
Commented out a print statement.
9b7116d
@kecnry
updates to distl and stuff to allow plotting
29c7a63
reinstate mixing code in backend
670df11
make function of two occurances of mixing in backends.py
119a3ef
rebuild default bundles
3362d9a
set default mix to false in component.py
8ea7a0f
implement perfect mixing
7f2d846
some documentation/description of the mixing methods
e8c4ff2
update default bundles with new choice
2b71ab1
add simple test of perfect mixing
aad340b
@kecnry
prepare readme and changelog for 2.4.18 bugfix
7a2d8fb
add simple test of perfect mixing
dd98ada
revert latitude computation
1c358cd
@matthiasfabry
simple longitude dependence
4734fd8
@matthiasfabry
weibull longitude dependence
bd032c2
@matthiasfabry
Merge remote-tracking branch 'origin/feature-contacts' into revive-co…
b97a6ea 
…ntact-smoothing

# Conflicts:
#	phoebe/frontend/default_bundles/default_binary.bundle
#	phoebe/frontend/default_bundles/default_contact_binary.bundle
#	phoebe/frontend/default_bundles/default_star.bundle
@matthiasfabry
add documentation
ae834bf
@matthiasfabry
pep8 formatting
2b72d1b
@matthiasfabry
use logger; descriptive ValueErrors
9a21b37
@matthiasfabry
remove spotty transfer cause too parametric
f321360
@matthiasfabry
gate energy transfer behind envelope requirement; rename to `energy_t…
bfee696 
…ransfer`
@matthiasfabry
add forbidden labels
41c536c
matthiasfabry and others added 19 commits September 5, 2025 14:17
@matthiasfabry
recompute def bundles
d0d13b4
@matthiasfabry
remove old implementation in universe.py
d80f250
@matthiasfabry
Revert "updates to distl and stuff to allow plotting"
e0250aa 
This reverts commit 29c7a63.
@matthiasfabry
Revert "recompute def bundles"
1f5484f 
This reverts commit d227197.
@matthiasfabry
update only relevant parameters in default bundles
820cb5c
@matthiasfabry
ET scales with temp ratio not linear approx
eaf0afa
@matthiasfabry
implement longitudinal dependence, change interface to mixing_params
0ee8178
@matthiasfabry
remove checking for .dev when loading bundle from file
5806bbe
@matthiasfabry
make mixing width a separate param
dd6c0dc
@matthiasfabry
floatarrayfixes
37ecb60
@matthiasfabry
don't redo radiosity/reflection for contact envelopes
741223f
@matthiasfabry
Revert "don't redo radiosity/reflection for contact envelopes"
ed32948 
This reverts commit f1e2595.
@kecnry @matthiasfabry
prepare readme and changelog for 2.4.18 bugfix
09256a2
@matthiasfabry
don't redo radiosity/reflection for contact envelopes
b0dae90
@matthiasfabry
populate the mesh halves after they have been split
4558612
@matthiasfabry
cleanup
0407fdd
@matthiasfabry
absorb mixing with into mixing_params
29d631e
@matthiasfabry
Merge remote-tracking branch 'origin/longitude-dependence' into longi…
8f57ad0 
…tude-dependence

# Conflicts:
#	phoebe/__init__.py
#	phoebe/backend/contacts_energy_transfer.py
#	phoebe/parameters/parameters.py
#	pyproject.toml
@matthiasfabry
fix radial mixing
ba5aece
@matthiasfabry

matthiasfabry commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator Author

Clearly I did the rebase incorrectly to fix the conflicts. Would a merge commit been better here? Or did I rebase incorrectly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthiasfabry @kecnry @gecheline @aprsa