Preserve unexpected Jepsen operation failures - #22
Open
jeregrine wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Jepsen Owner converted every implementation exception into an ordinary failed operation. The checker ignored those failures, allowing broken operations to shrink the workload and still qualify, even after their owner or VM disappeared.
Fix
Expected admission and ownership failures now have explicit stable codes. Timeouts and process unavailability remain indeterminate rather than definite rejection. Unexpected exceptions, throws, exits, and return values retain diagnostic evidence in the operation response and the durable oracle log instead of killing an Owner with a conflict-shaped reason.
The checker rejects unexpected operation evidence from the entire history independently of terminal survivor membership.
Supporting information
Disconnected-cluster ArgumentError classification is restricted to Group's admission function, not a broad exception type or message match. Actual Owner/Driver boundary regressions exercise both real Group admission failures and injected implementation faults. Conflict-death validation remains a separate change.