Retain snapshot commit evidence after installation - #25
Open
jeregrine wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The snapshot model's no-terminal-commit invariant checks only outstanding staging. Installation clears staging, making the invariant vacuously true precisely when it should reject an installation that never received a commit.
Fix
Retain the last installation's actual commit evidence independently of staging and assert that evidence. Ordinary model transitions and the finite state space are unchanged when projected onto the original variables.
The formal matrix also runs a negative qualification: remove the terminal-commit guard in an isolated model copy and require a safety violation specifically from
NoCommitMeansNoInstall. Mutant survival and parser/runtime failures fail qualification instead of receiving credit.Supporting information
The matrix now also requires Elixir to construct the isolated mutation and classify TLC's stable exit status. Individual model runs through
check.shstill need only Java andtla2tools.jar. Qualification artifacts remain under ignoredtmp/formal/for inspection.