Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing gettext invocations in core components #5665

Closed
wants to merge 3 commits into from
Closed

Add missing gettext invocations in core components #5665

wants to merge 3 commits into from

Conversation

sheerlox
Copy link
Contributor

Added gettext to flash_group default error flashes.

Manually tested by using the modified version of the generator and running mix gettext.extract:

image

@sheerlox
Copy link
Contributor Author

I tried to address the issue with formatting (which depends on whether gettext is used or not) in the last commit. Please let me know if you can think of a more elegant solution!

@rhcarvalho
Copy link
Contributor

There's some overlap with #5658 I sent last week :)

@sheerlox
Copy link
Contributor Author

There's some overlap with #5658 I sent last week :)

Oops, I should have checked! Closing in favor of yours 😄

@sheerlox sheerlox closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheerlox @rhcarvalho