Relocate check for context files generation into context generator. #6010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoke context files copy before parent generator files, to skip extra binding creation. It is not only skipping not used data passing in arguments, but also improve work with code as well (no need to double check if it is used data in context or not).
Also: - Apply same improvement for `print_shell_instructions` function. - There were auto-formatting triggered on save for `phx.gen.schema.ex` file.
josevalim
approved these changes
Mar 6, 2025
|
Looks like random failing tests. On forked side all tests have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocate check for context files generation into context generator.
Invoke context files copy before parent generator files, to skip extra binding creation. It is not only skipping not used data passing in arguments, but also improve work with code as well (no need to double check if it is used data in context or not).
Apply the same improvement to schema generation check.
There were auto-formatting triggered on save for
phx.gen.schema.exfile.