Make title optional in generated flash component #6065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sky as color to be more info-like for type :info. Relates to: #5969
SteffenDE
force-pushed
the
sd-rm-flash-title
branch
from
275029f to
99b808b
Compare
SteffenDE
commented
Jan 27, 2025
| <.flash | ||
| id="client-error" | ||
| kind={:error} | ||
| title=<%= maybe_heex_attr_gettext.("We can't find the internet", @gettext) %> |
There was a problem hiding this comment.
well maybe we do still want the title for those? @josevalim
There was a problem hiding this comment.
or we move the "Something went wrong!" part into the message
josevalim
reviewed
Jan 27, 2025
josevalim
reviewed
Jan 27, 2025
|
Slightly less bold |
|
Looks good! Do we want to add some breaks/vertical spacing? Maybe we render the same as before but without forcing a title on everyone? Alternatively we can make the title optional inside |
SteffenDE
force-pushed
the
sd-rm-flash-title
branch
from
92cad27 to
d0eea4e
Compare
|
Nah, ignore me. No need for spacing. Ship it! |
josevalim
approved these changes
Jan 27, 2025
|
It's no problem to make the title optional 
|
|
Yeah, whatever is less code then. :) |
SteffenDE
changed the title
josevalim
approved these changes
Jan 27, 2025
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sky as color to be more info-like for type :info.
Relates to: #5969
Multi-line messages
Info
I increased the icon size to match the text's line-height, otherwise it would not look aligned: