Display process label in application and process views#479
Merged
Conversation
josevalim
reviewed
May 25, 2025
| defp to_wrapped_node(type, pid, children) do | ||
| case Process.info(pid, :registered_name) do | ||
| {:registered_name, []} -> | ||
| case Process.info(pid, :label) do |
Member
There was a problem hiding this comment.
You need to read it from :dictionary, see this line as an example:
Can you also please add a test? thanks!
Contributor
Author
There was a problem hiding this comment.
Thanks, I updated the PR
SteffenDE
reviewed
May 25, 2025
| {:ancestors, | ||
| Keyword.get(dictionary, :"$ancestors", []) | ||
| |> Enum.map(&pid_or_port_details/1)}, | ||
| {:label, Keyword.get(dictionary, :"$process_label", [])} |
Member
There was a problem hiding this comment.
Should the default be nil instead? 🤔
Member
There was a problem hiding this comment.
Suggested change
| {:label, Keyword.get(dictionary, :"$process_label", [])} | |
| {:label, Keyword.get(dictionary, :"$process_label")} |
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I submitted #478 but I decided to try it myself.
Display process label in application view:
Display process label in process view: