pass fromEl and toEl to hook beforeUpdate #3616
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SteffenDE what's the status of this PR? I have a package that implements FLIP animations in a hook (LiveFLIP), and having the |
Relates to #3615. Allowing beforeUpdate to cancel an update by returning false is **not** implemented, as this would require more complex internal changes.
SteffenDE
force-pushed
the
sd-beforeUpdate
branch
from
55dbdd9 to
69cc407
Compare
|
@probably-not I wanted to get some feedback from @chrismccord first.. Apart from that I'd need to add some tests. I did not forget about this, so the goal is to release it in LiveView 1.1 if Chris is happy with it. You can try this change with {:phoenix_live_view, github: "phoenixframework/phoenix_live_view", branch: "sd-beforeUpdate-assets", override: true}and let me know if it works for you :) |
|
Thanks @SteffenDE! I'll try it out from the branch and see how things are working 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3516.
Relates to #3615.
Allowing beforeUpdate to cancel an update by returning false is not implemented, as this would require more complex internal changes.