allow auto-symlinking node_modules for ColocatedJS #3988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and document node_modules handling Closes #3985.
SteffenDE
commented
Sep 11, 2025
SteffenDE
commented
Sep 11, 2025
SteffenDE
commented
Sep 11, 2025
SteffenDE
force-pushed
the
sd-colo-symlink
branch
from
04478bb to
d7fc667
Compare
SteffenDE
commented
Sep 12, 2025
josevalim
reviewed
Sep 12, 2025
josevalim
reviewed
Sep 12, 2025
josevalim
reviewed
Sep 12, 2025
josevalim
reviewed
Sep 12, 2025
josevalim
reviewed
Sep 12, 2025
Co-authored-by: José Valim <[email protected]>
josevalim
approved these changes
Sep 14, 2025
SteffenDE
added a commit
that referenced
this pull request
Sep 14, 2025
* allow auto-symlinking node_modules for ColocatedJS and document node_modules handling Closes #3985. * relative symlinks, umbrella support * make node_modules_location a project config * make it work on Elixir 1.15 * fix * add test * don't link for dependencies * Update lib/phoenix_live_view/colocated_js.ex Co-authored-by: José Valim <[email protected]> * always symlink --------- Co-authored-by: José Valim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and document node_modules handling
Closes #3985.