Fix extra spaces being continually added when formatting nested inline tags #3995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e tags
In the case where an inline tag has a nested inline tag, and there are
spaces before and after text in the parent tag, extra spaces are
continually appended each time HTML is formatted (ie if formatting on
autosave in an editor, this keeps pumping on spaces every time a
template is saved)
This is funny when you spam save in neovim, and you see a little HTML
tag crawl across the buffer like a worm :D - but ends up in way too much
git diff spam
e.g.
```elixir
str = "<a> foo <b>bar</b></a>"
str
|> Phoenix.LiveView.HTMLFormatter.format([])
# "<a> foo <b>bar</b></a>\n"
str
|> Phoenix.LiveView.HTMLFormatter.format([])
|> Phoenix.LiveView.HTMLFormatter.format([])
"<a> foo <b>bar</b></a>\n"
str
|> Phoenix.LiveView.HTMLFormatter.format([])
|> Phoenix.LiveView.HTMLFormatter.format([])
|> Phoenix.LiveView.HTMLFormatter.format([])
"<a> foo <b>bar</b></a>\n"
```
josevalim
approved these changes
Sep 17, 2025
|
Thank you! 🙌🏻 |
SteffenDE
pushed a commit
that referenced
this pull request
Sep 18, 2025
…e tags (#3995) In the case where an inline tag has a nested inline tag, and there are spaces before and after text in the parent tag, extra spaces are continually appended each time HTML is formatted (ie if formatting on autosave in an editor, this keeps pumping on spaces every time a template is saved) This is funny when you spam save in neovim, and you see a little HTML tag crawl across the buffer like a worm :D - but ends up in way too much git diff spam e.g. ```elixir str = "<a> foo <b>bar</b></a>" str |> Phoenix.LiveView.HTMLFormatter.format([]) # "<a> foo <b>bar</b></a>\n" str |> Phoenix.LiveView.HTMLFormatter.format([]) |> Phoenix.LiveView.HTMLFormatter.format([]) "<a> foo <b>bar</b></a>\n" str |> Phoenix.LiveView.HTMLFormatter.format([]) |> Phoenix.LiveView.HTMLFormatter.format([]) |> Phoenix.LiveView.HTMLFormatter.format([]) "<a> foo <b>bar</b></a>\n" ```
zekedou
added a commit
to combo-lab/combo
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where an inline tag has a nested inline tag, and there are spaces before and after text in the parent tag, extra spaces are continually appended each time HTML is formatted (ie if formatting on autosave in an editor, this keeps pumping on spaces every time a template is saved)
This is funny when you spam save in neovim, and you see a little HTML tag crawl across the buffer like a worm 😆 - but ends up in way too much git diff spam
Screen.Recording.2025-09-16.at.5.47.25.pm.mov
e.g.
Check if text whitespace is being preserved, and don't add
flex_break(" ")if so, just allowingcondblock to drop down and add""as a separator in this case.