Skip to content

Fix to issue #4015 #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
+3 −20,465
Closed

Fix to issue #4015 #4016

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
70dcfa7
fixed the innerText issue
Yashaswini-Sharma Oct 10, 2025
7502fcc
Remove test files - keep only view.js changes
Yashaswini-Sharma Oct 10, 2025
d9d6f16
Added a comment explaining the change
Ssinha254 Oct 10, 2025
1018daf
Update assets/js/phoenix_live_view/view.js
SteffenDE Oct 10, 2025
5e794b7
Revert priv/static files
Yashaswini-Sharma Oct 10, 2025
7355e62
Merge branch 'main' of github.com:Yashaswini-Sharma/phoenix_live_view
Yashaswini-Sharma Oct 10, 2025
d584df3
Remove priv/static files and add to .gitignore
Yashaswini-Sharma Oct 10, 2025
f09e26f
Update .gitignore
SteffenDE Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions assets/js/phoenix_live_view/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1350,10 +1350,11 @@ export default class View {
const disableText = el.getAttribute(disableWith);
if (disableText !== null) {
if (!el.getAttribute(PHX_DISABLE_WITH_RESTORE)) {
el.setAttribute(PHX_DISABLE_WITH_RESTORE, el.innerText);
el.setAttribute(PHX_DISABLE_WITH_RESTORE, el.textContent);
// Replaced innerText with textContent to prevent changing HTML element
}
if (disableText !== "") {
el.innerText = disableText;
el.textContent = disableText;
}
// PHX_DISABLED could have already been set in disableForm
el.setAttribute(
Expand Down
4 changes: 2 additions & 2 deletions priv/static/phoenix_live_view.cjs.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions priv/static/phoenix_live_view.cjs.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions priv/static/phoenix_live_view.esm.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions priv/static/phoenix_live_view.esm.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions priv/static/phoenix_live_view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5071,10 +5071,10 @@ removing illegal node: "${(childNode.outerHTML || childNode.nodeValue).trim()}"
const disableText = el.getAttribute(disableWith);
if (disableText !== null) {
if (!el.getAttribute(PHX_DISABLE_WITH_RESTORE)) {
el.setAttribute(PHX_DISABLE_WITH_RESTORE, el.innerText);
el.setAttribute(PHX_DISABLE_WITH_RESTORE, el.textContent);
}
if (disableText !== "") {
el.innerText = disableText;
el.textContent = disableText;
}
el.setAttribute(
PHX_DISABLED,
Expand Down
2 changes: 1 addition & 1 deletion priv/static/phoenix_live_view.min.js
View file
Open in desktop

Large diffs are not rendered by default.