Add Phoenix.PubSub.subscribe_once/3
#199
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the possibility of duplicate subscriptions was already discussed in the docs on
subscribe/3
, I assume there's a performance cost to checking for existing subscriptions that callers may not always want to pay. If so, I'd be happy to document that onsubscribe_once/3
. But it seems useful to have this function; I'm looking at a use case where the number of subscriptions to a topic won't be large but duplicate messages would be problematic.Currently, any caller who wants to avoid duplicate subscriptions would need to use some kind of workaround, such as:
subscribe/3
more than once by tracking subscriptions in their own process state, or by checkingRegistry.lookup/2
directly (relying on an implementation detail of PubSub)unsubscribe/2
each time before callingsubscribe/3