Skip to content
This repository was archived by the owner on Apr 2, 2026. It is now read-only.

Node 10 requires a callback to rmdir #69

Open
gust42 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Node 10 requires a callback to rmdir #69

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80e42cb
Node 10 requires a callback to rmdir
gust42 Nov 5, 2018
9bb102a
updated test
gust42 Nov 5, 2018
58aff67
learned a bit jasmine
gust42 Nov 5, 2018
89f1075
Changed to rmdirSync
gust42 Nov 6, 2018
e52f796
tests...
gust42 Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/phonegap-build/create/zip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ module.exports = {
// remove zip directory if empty
exists = fs.existsSync(basepath);
if (exists) {
fs.rmdir(basepath);
fs.rmdir(basepath, function () {});
Copy link
Copy Markdown

@sebastianjonasson sebastianjonasson Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the sync function is used above in fs.existsSync, you might want to use fs.rmdirSync instead.

Copy link
Copy Markdown
Author

@gust42 gust42 Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good point!

}
}
};