This repository was archived by the owner on Sep 4, 2020. It is now read-only.
Foreground indicator fixed for VoIP notifications#2728
Open
jlorente wants to merge 3 commits intophonegap:masterfrom
Open
Foreground indicator fixed for VoIP notifications#2728jlorente wants to merge 3 commits intophonegap:masterfrom
jlorente wants to merge 3 commits intophonegap:masterfrom
Conversation
Contributor
Author
|
I have seen the error in the tests, but I have not changed the js code. |
Contributor
Author
|
I have merged the latests commits of the repository and now the tests have passed. |
emilio-ferrer
approved these changes
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foreground indicator fixed for VoIP notifications
Description
Foreground attribute in additionaData payload was always false for VoIP notifications. With this
fix, it takes the properly value.
Related Issue
#2368
How Has This Been Tested?
With Xcode 10.
Types of changes
Checklist: