forked from schmittjoh/JMSTranslationBundle
-
Notifications
You must be signed in to change notification settings - Fork 1
Rebase to upstream 12-4-24 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michealmouner
wants to merge
140
commits into
php-community:master
Choose a base branch
from
lingoda:rebase-to-upstream-12-4-24
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rebase to upstream 12-4-24 #1
michealmouner
wants to merge
140
commits into
php-community:master
from
lingoda:rebase-to-upstream-12-4-24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import Message, fixes schmittjoh#508
'#filter' may not exist causing a JS fatal error
Test if filter exists before use
Remove deprecated usage of TreeBuilder on Symfony 4
Update for Symfony 4.1
Not sure since when, but parsing is not enough to obtain the same code from different fixtures. Adding that extra step fixes the failing tests and the build.
Compile nodes before comparing them
Address namespace change in Twig
Drop symfony < 3.4 and < 4.3 for 4.x
Remove duplicated packages in composer
Test minimum requirements
Cleanup tests
Replace kernel.root_dir with kernel.project_dir
…ment Support named argument for domain extraction
PR resolves this deprecation: Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "JMS\TranslationBundle\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.
resolved deprecation notice with Symfony 5.4
…sio-framework-extra-bundle Allow to use translate controller without sensio/framework-extra-bundle
Use github actions ci
symfony 6 support
Fix --intl-icu option
Handle properly promoted constructor properties default values
Resolve pull request schmittjoh#576
Fix schmittjoh#575: Remove deprecation notices with string interpolation
Merge back 1.x into master
…on-fixes Add void return signatures to remove deprecation notices
Fix coding style
Add attributes for routes
…n version is installed
Fix wrong return type-hint depending on which symfony/translation version is installed
chore(deps): upgrade nikic/php-parser@^5
fix: prevent type error on choices array with optional keys
# Conflicts: # Tests/Translation/Extractor/File/FormExtractorTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
Todos