-
Notifications
You must be signed in to change notification settings - Fork 56
adjust documentation to PSR-17 and PSR-18 #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
The socket client uses the stream extension from PHP, which is integrated into | ||
the core. | ||
|
||
This client only implements the PHP-HTTP synchronous interface, which has been | ||
superseded by PSR-18. Use one of the PSR-18 clients instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joelwurtz @Nyholm i think you 2 mostly worked on the socket client. as it does not implement async and is quite inactive, i think we should deprecate it in favor of using PSR-18 clients.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the package should be updated, or marked abondonded. Not sure what we're waiting for 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wanted to give some time to react for the authors of the package who are part of the php-http group.
but no reaction is also a kind of statement on priorities. i can't promise that i can get to it very soon however, as i have a holidays coming up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i archived all repositories except for socket which seems to still gather some interest. i pinged the person who tried to update it recently if they want to keep maintaining it. |
…lete PHP-HTTP adapters and clients
What's in this PR?
deprecate a couple of obsolete PHP-HTTP adapters and clients
remove instructions to install discovery where the clients/adapters require it directly anyways.