Add token price and maxTime parameters #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Can you check CI failures though? |
|
@ostrolucky sure |
|
@ostrolucky Sorry, I think I need some help with this build "Unit tests (7.4, lowest) (pull_request)" |
|
Ok I'll investigate, thanks |
|
the new parameters should be documented - but actually the whole plugin is missing an entry in the documentation repository. i created #5, would be awesome if one of you has time to document it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR introduces two new parameters to the existing functionality:
Why?
This PR addresses the need to manage the number of tokens and the maximum waiting time in the application, providing more control over these parameters and enhancing the flexibility of the system.
And most importantly, it allows setting a maximum waiting time for blocking, making it easy to fall back when the limit is reached.