Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not add a dummy function when functionName is not provided #14

Merged

Conversation

michalbundyra
Copy link
Member

@michalbundyra michalbundyra commented Mar 8, 2025

/cc @crocodele

From what you have done any my tests it looks like that signature of this method (parameters) does not really matter.
So I am happy to keep it without, unless you see a potential issue with it? Thanks

@michalbundyra michalbundyra added this to the 3.0.0 milestone Mar 8, 2025
@michalbundyra michalbundyra merged commit 8ceb860 into php-mock:master Mar 8, 2025
14 checks passed
@michalbundyra michalbundyra deleted the mock-build-no-function-name branch March 8, 2025 19:22
@crocodele
Copy link
Contributor

From what you have done any my tests it looks like that signature of this method (parameters) does not really matter. So I am happy to keep it without, unless you see a potential issue with it? Thanks

I haven't noticed any issues either, so I hope it's OK. 🙂 At one point I was thinking that the method with the correct name perhaps could completely replace the delegate() method, but that would have been a bigger change and I don't know if it (1.) would work as expected and (2.) have any side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants