-
Notifications
You must be signed in to change notification settings - Fork 93
Remove Twig deprecations #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove Twig deprecations #519
Conversation
c0e0046
to
58d2ca8
Compare
For this we must raise the twig min. version in |
58d2ca8
to
ba25a6e
Compare
Raised to Twig 3.12 |
3.12 was release in August 2024, not sure if that bump is considered to be too big? |
ba25a6e
to
7c7474e
Compare
I open a PR to only fix the i also agree with @rvanlaak but we should only support twig releases for 1 year. What do you think @bocharsky-bw? |
7c7474e
to
3bfdb5d
Compare
I moved AbstractNodeVisitor here to this bundle, deprecation about Twig's AbstractNodeVisitor beeing deprecated should be therefore resolved. I also levereaged existence of this class to add metod to add functionality for getting the value from node, and here is specific method distinguished by Twig version - which should also remove deprecations and ensure older Twig version support |
You can simply put your |
No description provided.