Conversation
c0e0046 to
58d2ca8
Compare
|
For this we must raise the twig min. version in |
58d2ca8 to
ba25a6e
Compare
|
Raised to Twig 3.12 |
|
3.12 was release in August 2024, not sure if that bump is considered to be too big? |
ba25a6e to
7c7474e
Compare
|
I open a PR to only fix the i also agree with @rvanlaak but we should only support twig releases for 1 year. What do you think @bocharsky-bw? |
7c7474e to
3bfdb5d
Compare
|
I moved AbstractNodeVisitor here to this bundle, deprecation about Twig's AbstractNodeVisitor beeing deprecated should be therefore resolved. I also levereaged existence of this class to add metod to add functionality for getting the value from node, and here is specific method distinguished by Twig version - which should also remove deprecations and ensure older Twig version support |
|
You can simply put your |
Me neither.
Hm, I would like to keep the version not too high to support more legacy projects. But we still talk about the same major v3 of Twig, so maybe that's not a big deal to bump to v3.12. If we can't avoid so high bump and those depreciations really annoy us - I'm fine with this bump. |
No description provided.