Skip to content

Use &true;/&false;/&null; entities for boolean/null constants#5641

Merged
jordikroon merged 3 commits into
php:masterfrom
lacatoire:fix/boolean-literals-to-entities
Jul 9, 2026
Merged

Use &true;/&false;/&null; entities for boolean/null constants#5641
jordikroon merged 3 commits into
php:masterfrom
lacatoire:fix/boolean-literals-to-entities

Conversation

@lacatoire

Copy link
Copy Markdown
Member

Replaces <literal>true/false/null</literal> with the standard &true;/&false;/&null; entities where they denote the PHP boolean/null constant (26 occurrences, 21 files).

Quoted strings, JSON/INI literals, SQL NULL and type notations were reviewed and intentionally left untouched. Inline-only <para> touched by the change are converted to <simpara> (DocBook style check).

Replace <literal>true/false/null</literal> with the standard entities where they
denote the PHP boolean/null constant. Quoted strings, JSON/INI literals, SQL NULL
and type notations are intentionally left untouched.
Required by the DocBook style check on the paragraphs modified by this PR.
@lacatoire
lacatoire requested a review from kamil-tekiela as a code owner June 30, 2026 13:07
Return the domain and username or username if domain is <literal>null</literal> or &null; if no username found.
</para>
<simpara>
Return the domain and username or username if domain is &null; or &null; if no username found.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rewrite this. I agree this should be &null;, but now it's more confusing to read then it already was.

@jordikroon
jordikroon merged commit 911fe79 into php:master Jul 9, 2026
2 checks passed
@lacatoire
lacatoire deleted the fix/boolean-literals-to-entities branch July 9, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants