DTD to XML convert extensions.ent#5697
Open
alfsb wants to merge 3 commits into
Open
Conversation
alfsb
changed the title
jordikroon
approved these changes
Jul 22, 2026
jordikroon
left a comment
jordikroon
left a comment
Member
There was a problem hiding this comment.
This makes sense. Looks good to me.
jordikroon
reviewed
Jul 22, 2026
| </simpara> | ||
| </entity> | ||
|
|
||
| <entity name="extcat.purpose"><title>Purpose</title></entity> |
Member
There was a problem hiding this comment.
Upon closer look, extcat.purpose.* are not used anymore. Should we move these to entities-remove.ent instead?
Member
Author
There was a problem hiding this comment.
Oh, I didn't catch that. For entities not used anywhere, direct deletion is the way. I will test and erase them before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversion of another DTD entity file into XML entity format. Reindented and fixed some typography. Uncovered an error in
text-entities.php --debug, to be fixed later.Comments and reviews wellcome. Plan to merge this in one week.