ext/pdo: PHP 8.4 changes across PDO, PDO_PGSQL and PDO_Firebird#5703
Open
lacatoire wants to merge 5 commits into
Open
ext/pdo: PHP 8.4 changes across PDO, PDO_PGSQL and PDO_Firebird#5703lacatoire wants to merge 5 commits into
lacatoire wants to merge 5 commits into
Conversation
Member
Member
|
I propose that when we create PRs for new language changes, we link the commit/PR/RFC so that it's easier to verify the changes. Right now, I need to go on a research sidequest to understand what's changed. |
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
…o pre-8.4 getattribute.xml: PDO::getAttribute handles exactly 8 generic attributes (pdo_dbh.c PDO::getAttribute switch); the simplelist listed 7 driver-specific ones and missed STATEMENT_CLASS/DEFAULT_FETCH_MODE. Replace it with the 8 generic attributes (STRINGIFY_FETCHES fetchable as of 8.4, php-src#12793). prepare.xml: the default 8.4 parser (pdo_sql_parser.re) recognises doubled quotes, not backslash escapes, so the note about backslash escapes now describes pre-8.4 behaviour; scope it accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the PHP 8.4 changes across the PDO family.
PDO core
PDO_PGSQL
PDO_Firebird
Sources