Skip to content

Closing old issues before convertion.#5704

Merged
alfsb merged 1 commit into
php:masterfrom
alfsb:removes
Jul 24, 2026
Merged

Closing old issues before convertion.#5704
alfsb merged 1 commit into
php:masterfrom
alfsb:removes

Conversation

@alfsb

@alfsb alfsb commented Jul 23, 2026

Copy link
Copy Markdown
Member

Move some long erased entities into entities.remove.ent, so issues can be closed and empty files deleted.

Plan to merge this in early August.

@alfsb

alfsb commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

This allowed the erasing of contribuitors.ent, and will allow the merging of php/doc-base#143 .

translate = "remove">

<!-- Erased in 2026-06, long time empty -->
<!-- Erased in 2024-08, doc-ru -->

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this file will get longer should we have a convention for adding lines? This should also make it easier for other contributors to phase out entities.

Perhaps something like:
<!-- Erased in <date>, ref: #3633, todo: doc-<lang>, doc-<lang> -->

<!-- Erased in <date>, ref: */bookinfo.xml, todo: doc-<lang> -->

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These conventions are good, and please add them to new entries.

But as this file may grow and be rarely trimmed, or have its comments updated, I think the only real way this file will be reduced is with bruteforce testing its contents against all languages, from time to time.

I was working in an "exact" userland XML assembler that could be used instead, but as it is constantly sidestepped, and my time in docs grows thin, I can only think in the bruteforce alternative for the future, where exact or updated comments may have low impact in the end.

@kamil-tekiela kamil-tekiela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wait until August? You can merge it now.

@alfsb

alfsb commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

At first I worried this would conflict with manual split (and so, August). But nothing clashed, I will merge it later today.

@alfsb
alfsb merged commit 75772fd into php:master Jul 24, 2026
2 checks passed
@alfsb
alfsb deleted the removes branch July 24, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants