Improves and unifies indentation handling - #56
Open
NickSdot wants to merge 2 commits into
Open
Conversation
Co-authored-by: Lars Moelleken <lars@moelleken.org>
NickSdot
force-pushed
the
feat/indentation
branch
from
September 6, 2026 14:21
f62c8e6 to
8f57472
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47.
Introduces one universal
IndentationFixer; replacesMixedIndentationFixer.Edit: depends on #55, hence CI style failure here
Aside: To make this work we needed something like the
$fixerDataapproach @voku adds in #45. I tried a few alternatives but they ended up more awkward and/or verbose -- his approach is the right call. I cherry picked his commit and stripped out what's not relevant for here; would be nice to not squash-merge this to give him credit for the work in the commit. 🫡