Skip to content

ext/session: Remove redundant parentheses in session tests #23609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamil-tekiela wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/session: Remove redundant parentheses in session tests #23609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/session/tests/001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ session object serialization
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.cache_limiter=
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/002.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ session_unset() without a initialized session
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--FILE--
<?php
error_reporting(E_ALL);
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ session object deserialization
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_strict_mode=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/006.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ correct instantiation of references between variables in sessions
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_strict_mode=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/009.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ unset($_SESSION["name"]); test
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_strict_mode=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/010.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ $session_array = explode(";", session_encode()); should not segfault
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.cache_limiter=
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/011.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ session_decode(); should not segfault
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.cache_limiter=
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/012.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ registering $_SESSION should not segfault
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_strict_mode=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/013.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ redefining SID should not cause warnings
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_strict_mode=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/014.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ a script should not be able to modify session.use_trans_sid
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_trans_sid=0
session.use_cookies=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/015.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use_trans_sid should not affect SID
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_trans_sid=1
session.use_cookies=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/017.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ setting $_SESSION before session_start() should not cause segfault
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.cache_limiter=
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/018.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ rewriter correctly handles attribute names which contain dashes
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_only_cookies=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/019.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ serializing references test case using globals
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_strict_mode=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/020.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ rewriter uses arg_separator.output for modifying URLs
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_only_cookies=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/021.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ rewriter handles form and fieldset tags correctly
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_only_cookies=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/023.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ session object deserialization
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_strict_mode=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/026.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ correct instantiation of references between variables in sessions
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_strict_mode=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/027.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ unset($_SESSION["name"]); should work
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_strict_mode=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/029.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ session_decode(); should not segfault
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.cache_limiter=
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/SID_type_confusion.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ SID constant type confusion
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_only_cookies=1
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug24592.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #24592 (crash when multiple NULL values are being stored)
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
html_errors=0
session.save_handler=files
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug26862.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #26862 (ob_flush() before output_reset_rewrite_vars() results in data loss)
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
html_errors=0
session.use_trans_sid=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug36459.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #31454 (Incorrect adding PHPSESSID to links, which contains \r\n)
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_trans_sid=1
session.use_cookies=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug38377.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #38377 (session_destroy() gives warning after session_regenerate_id())
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--FILE--
<?php
session_start();
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug41600.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #41600 (url rewriter tags doesn't work with namespaced tags)
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_cookies=0
session.use_only_cookies=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug42596.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ session
--SKIPIF--
<?php
if(substr(PHP_OS, 0, 3) == "WIN") die("skip not for Windows");
include('skipif.inc');
include 'skipif.inc';
?>
--INI--
session.use_cookies=0
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug50308.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #50308 (session id not appended properly for empty anchor tags)
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.name=PHPSESSID
session.save_handler=files
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug51338.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #51338 (URL-Rewriter should not get enabled if use_only_cookies is set to 1)
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_only_cookies=1
session.use_trans_sid=1
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug53141.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #53141 (autoload misbehaves if called from closing session)
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--FILE--
<?php
spl_autoload_register(function ($class) {
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug61470.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #61470 (session_regenerate_id() does not create session file)
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--FILE--
<?php
ob_start();
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug65475.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ session.name=PHPSESSID
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--FILE--
<?php
ob_start();
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug66481.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ error_log=
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--FILE--
<?php
ob_start();
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug66827.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #66827: Session raises E_NOTICE when session name variable is array.
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--FILE--
<?php
$_COOKIE[session_name()] = array();
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug67694.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ date.timezone = UTC
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--FILE--
<?php
ob_start();
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug68063.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #68063 (Empty session IDs do still start sessions)
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.use_strict_mode=0
session.sid_length=40
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug70013.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #70013 (Reference to $_SESSION is lost after a call to session_regenerate_id
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.save_handler=files
--FILE--
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug70876.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #70876 Segmentation fault when regenerating session id with strict mode
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
html_errors=0
session.save_handler=files
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug71683.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #71683 Null pointer dereference in zend_hash_str_find_bucket
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.save_handler=files
session.auto_start=1
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug71972.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #71972 (Cyclic references causing session_start(): Failed to decode session
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
session.save_handler=files
--FILE--
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug71974.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #71974 Trans sid will always be send, even if cookies are available
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--INI--
display_startup_errors=0
session.save_handler=files
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug72562.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #72562: Use After Free in unserialize() with Unexpected Session Deserializat
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--FILE--
<?php

Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug72681.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bug #72681: PHP Session Data Injection Vulnerability
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--FILE--
<?php
ini_set('session.serialize_handler', 'php');
Expand Down
2 changes: 1 addition & 1 deletion ext/session/tests/bug72940.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ session.save_handler=files
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php include 'skipif.inc'; ?>
--COOKIE--
PHPSESSID=bug72940test
--GET--
Expand Down
Loading
Loading