Fix Closure::fromCallable and first-class callables not propagating templates. #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mad-briller
commented
Mar 9, 2024
mad-briller
commented
Mar 9, 2024
| * @param callable(N): O $cd | ||
| * @return Closure(array{L, N}): array{M, O} | ||
| */ | ||
| function compose2(callable $ab, callable $cd): Closure |
There was a problem hiding this comment.
i had to change the generic type names of this function from A B C D to something else, as identity() and identity2() are also using A and B as generic type names, which made the type resolution fail. Been trying to dig into it a bit but as for why i'm really not sure right now,
There was a problem hiding this comment.
could this be related to TemplateTypeScope? i'm yet to properly understand it's role in the type resolution but it seems like it could be pertinent
mad-briller
force-pushed
the
fix-fc-callable
branch
from
f0b8ac3 to
0334026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves the
array_mapreturn type extension to be smarter about generic callables, specifically for single argument constant arrays.This improves the situation of phpstan/phpstan#10685 but i hesitate to say it solves it, there are some underlying issues that i'll add to the relevant test locations on this pr