Fix readonly property assign with ArrayAccess offset #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
readonly-property-assign-array-access
branch
2 times, most recently
from
770d90c to
25886a1
Compare
herndlm
force-pushed
the
readonly-property-assign-array-access
branch
from
25886a1 to
72a7433
Compare
herndlm
force-pushed
the
readonly-property-assign-array-access
branch
from
72a7433 to
dce9aa0
Compare
|
sorry boss, didn't want to hog CI, but thought it would be a good idea to rebase the last 3 non-controversial PRs from me 😊 |
herndlm
force-pushed
the
readonly-property-assign-array-access
branch
from
dce9aa0 to
3780c4a
Compare
herndlm
force-pushed
the
readonly-property-assign-array-access
branch
from
3780c4a to
6d50c11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#8929
Closes phpstan/phpstan#12537
UPDATE: added test for 8929 and dealing with unset after realizing the bug duplicate and also finding #3795. I don't mind which one gets merged first, anybody feel free to re-use parts from here in the other MR or directly.