Skip to content

Add commas to number #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edlinkiii wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add commas to number #469

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a3a2590
Add addDelimeter
edlinkiii Aug 27, 2021
d7384d5
Add addCommas
edlinkiii Aug 27, 2021
3a2cdea
Remove check
edlinkiii Aug 30, 2021
575e409
Conflicting package.json
edlinkiii Aug 30, 2021
9f37c11
Resolve conflict
edlinkiii Sep 8, 2021
9244bff
Resolve conflict
edlinkiii Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions collections/number/add-commas-to-number.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
~~~ javascript
const addCommas = (num) => (!num) ? null : num.toString().split('.').map((n,i) => (i === 0) ? n.replace(/\B(?=(\d{3})+(?!\d))/g, ',') : n).join('.');
Copy link
Owner

@phuocng phuocng Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the check !num? All of snippets assume that users pass valid parameters. So it looks like

const addCommas = (num) => [...`${num}`].map(...)

Copy link
Author

@edlinkiii edlinkiii Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

Copy link
Author

@edlinkiii edlinkiii Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it good now?


// addCommas(9999999.9999) === "9,999,999.9999"
~~~
Loading