Skip to content

Make peaks (and troughs) addition more robust to spanning issues and support newer python versions #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2025
Merged

Make peaks (and troughs) addition more robust to spanning issues and support newer python versions #94

merged 3 commits into from
Nov 25, 2025
+1,140 −569

Conversation

@smoia
Copy link
Member

@smoia smoia commented Nov 14, 2025

Closes #

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the Minormod This PR generally closes an "Enhancement" issue. It increments the minor version (0.+1.0) label Nov 14, 2025
@github-actions github-actions bot added the Testing This is for testing features, writing tests or producing testing code. label Nov 14, 2025
@github-actions github-actions bot added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Nov 14, 2025
@smoia smoia changed the title Support newer python versions Make peaks (and troughs) addition more robust to spanning issues and support newer python versions Nov 25, 2025
@smoia smoia removed Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog Testing This is for testing features, writing tests or producing testing code. labels Nov 25, 2025
@smoia smoia merged commit 3f1d367 into physiopy:master Nov 25, 2025
3 checks passed
@smoia
Copy link
Member Author

smoia commented Nov 25, 2025

🚀 PR was released in 0.6.0 🚀

@smoia smoia added the released This issue/pull request has been released label Nov 25, 2025
@smoia smoia deleted the enh/newerpython branch November 25, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@smoia smoia

Labels

Minormod This PR generally closes an "Enhancement" issue. It increments the minor version (0.+1.0) released This issue/pull request has been released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@smoia