Skip to content

Conversation

@me-pic
Copy link
Contributor

@me-pic me-pic commented Oct 16, 2025

Closes #485

Proposed Changes

  • Change urllib to requests

Change Type

  • [] bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@github-actions github-actions bot added the Testing This is for testing features, writing tests or producing testing code label Oct 16, 2025
@me-pic me-pic requested a review from smoia October 16, 2025 21:22
@smoia
Copy link
Member

smoia commented Oct 17, 2025

@me-pic what was the problem with the previous implementation?
Please add requests in the setup.cfg file, section [extra requires] tests - otherwise the automated tests will fail!

@github-actions github-actions bot added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Oct 17, 2025
@me-pic
Copy link
Contributor Author

me-pic commented Oct 17, 2025

Thank for taking a look at the PR @smoia ! The problem with the previous implementation is detailed in issue #485 . Let me know if you are able to replicate it !

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.15%. Comparing base (63c3d83) to head (e3eff0a).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files           8        8           
  Lines        1006     1006           
=======================================
  Hits          917      917           
  Misses         89       89           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@smoia smoia merged commit 4261d19 into physiopy:master Oct 18, 2025
10 checks passed
@welcome
Copy link

welcome bot commented Oct 18, 2025

Thank You Banner
🎉 Congrats on merging your first pull request in this repo! We appreciate your contribution to the Physiopy community! 👀 Please check that your contribution is correctly reported in the README of this repo and on Physiopy's website!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog Testing This is for testing features, writing tests or producing testing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error retrieving test data

2 participants