-
Notifications
You must be signed in to change notification settings - Fork 48
Fix files fetching from osf #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
|
@me-pic what was the problem with the previous implementation? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 8 8
Lines 1006 1006
=======================================
Hits 917 917
Misses 89 89 🚀 New features to boost your workflow:
|
smoia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
|
|

Closes #485
Proposed Changes
urllibtorequestsChange Type
bugfix(+0.0.1)minor(+0.1.0)major(+1.0.0)refactoring(no version update)test(no version update)infrastructure(no version update)documentation(no version update)otherChecklist before review