-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to remove/replace outdated references #1099
base: release/v6.0
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Would you mind checking all the other |
This page will also need to be changed: https://docs.pi-hole.net/group_management/example/ |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
3813ae0
to
e3d537b
Compare
Signed-off-by: Adam Warner <[email protected]>
Signed-off-by: Adam Warner <[email protected]>
Conflicts have been resolved. |
…date config setting instructions Signed-off-by: Adam Warner <[email protected]>
docs/ftldns/blockingmode.md
Outdated
@@ -9,7 +9,7 @@ Pi-hole *FTL*DNS currently supports the following modes for blocking queries: | |||
Each mode has their advantages and drawbacks which will be discussed in detail below. | |||
|
|||
!!! note | |||
In order to configure a blocking mode, you must edit the *FTL*DNS configuration file (`/etc/pihole/pihole-FTL.conf`). Once you've made any changes to the blocking mode, you must restart Pi-hole with `pihole restartdns`. | |||
In order to configure a blocking mode, you must edit the *FTL*DNS configuration file (`/etc/pihole/pihole-FTL.conf`). Once you've made any changes to the blocking mode, you must restart Pi-hole FTL (e.g `sudo service pihole-FTL restart` `sudo systemctl restart pihole-FTL`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to configure a blocking mode, you must edit the *FTL*DNS configuration file (`/etc/pihole/pihole-FTL.conf`). Once you've made any changes to the blocking mode, you must restart Pi-hole FTL (e.g `sudo service pihole-FTL restart` `sudo systemctl restart pihole-FTL`). | |
In order to configure a blocking mode, you must edit the *FTL*DNS configuration file (`/etc/pihole/pihole.toml`). Once you've made any changes to the blocking mode, you must restart Pi-hole FTL (e.g `sudo service pihole-FTL restart` `sudo systemctl restart pihole-FTL`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already coming in the next commit... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to wait until you request review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured I would go down a bit of a rabbit hole and try to update some of the outdated sections, too. In two minds about what to do with the ftldns/configfile/
page...
- Copy paste the current
pihole.toml
into this page as an online reference (with a reference to refer to the actual file for any up to date information - Remove the page entirely
- (I know, I said two minds) put a small blurb about the existence of
pihole.toml
and that it is fully commented to describe each section (or to use the web interface)
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go for three and add a link to https://ftl.pi-hole.net/master/docs/#get-/config
(currently development
) if users only want to get a list of possible config options.
01dd109
to
87804ec
Compare
Signed-off-by: Adam Warner <[email protected]>
@yubiuser - ready for a review at this stage. There may be more to come, but I'm tired.... |
369646e
to
282cf1a
Compare
…t -> allowlist/denylist Signed-off-by: Adam Warner <[email protected]>
What does this PR aim to accomplish?:
Companion PR to pi-hole/pi-hole#5779
By submitting this pull request, I confirm the following:
git rebase
)