Skip to content

Improve DNS upstream table #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yubiuser wants to merge 4 commits into
base: development
Choose a base branch
from
+89 −39
Open

Improve DNS upstream table #3827

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2691919
Fix DNS upstream table
yubiuser Jul 28, 2026
4914bf7
Simplify selector
yubiuser Jul 28, 2026
3fb6e7a
Also remove empty lines
yubiuser Jul 31, 2026
db57bf1
Filter table-selected upstreams from the custom upstream server input…
yubiuser Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/js/settings-dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,14 @@ function fillDNSupstreams(value, servers) {

// Add event listener to checkboxes (shared across the Plain/DoT/DoH tabs)
$("input[id^='DNSupstreams-']").on("change", () => {
const upstreams = $("#DNSupstreamsTextfield").val().split("\n");
const upstreams = $("#DNSupstreamsTextfield").val().split(/\r?\n/u).filter(Boolean);
Comment thread
Copilot marked this conversation as resolved.
Outdated
let customServerCount = 0;
$("#DNSupstreamsTable input").each(function () {
$("#DNSupstreamTabs table input").each(function () {
const title = $(this).closest("td").attr("title");
if (!title) {
return;
}

if (this.checked && !upstreams.includes(title)) {
// Add server to array
upstreams.push(title);
Expand Down
2 changes: 1 addition & 1 deletion settings-dns.lp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ mg.include('scripts/lua/settings_header.lp','r')
<div class="box-body">
<div class="row">
<div class="col-sm-12">
<div class="nav-tabs-custom">
<div class="nav-tabs-custom" id="DNSupstreamTabs">
<ul class="nav nav-tabs" role="tablist">
<li class="active" role="presentation">
<a href="#tab-upstreams-plain" aria-controls="tab-upstreams-plain" aria-expanded="true" role="tab" data-toggle="tab">Plain <span class="label label-primary" id="upstreams-count-plain" style="display: none;"></span></a>
Expand Down