Skip to content

Update datatables - #3841

Open
yubiuser wants to merge 3 commits into
developmentfrom
update/datatables
Open

Update datatables#3841
yubiuser wants to merge 3 commits into
developmentfrom
update/datatables

Conversation

@yubiuser

@yubiuser yubiuser commented Aug 6, 2026

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

I thought I just give it a shot.

Package From To
datatables.net 2.3.8 3.0.1
datatables.net-bs5 2.3.8 3.0.1
datatables.net-buttons 3.2.6 4.0.1
datatables.net-buttons-bs5 3.2.6 4.0.1
datatables.net-select 3.1.3 4.0.0
datatables.net-select-bs5 3.1.3 4.0.0

Certainly will break things at the beginning.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: yubiuser <github@yubiuser.dev>
Base automatically changed from fix/dns_revservers_table to development August 6, 2026 07:51
@yubiuser
yubiuser force-pushed the update/datatables branch 2 times, most recently from a5d87cc to 7f8085f Compare August 6, 2026 08:46
Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser
yubiuser force-pushed the update/datatables branch from 7f8085f to a5b4f0f Compare August 6, 2026 08:52
Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser

yubiuser commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

Ok, it now renders without errors. I think it doesn't look bad (at least not worse than development looks right now). Ready for input.

@yubiuser
yubiuser marked this pull request as ready for review August 6, 2026 09:25
@yubiuser
yubiuser requested a review from a team as a code owner August 6, 2026 09:25

@DL6ER DL6ER left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSRF change needs a word in the PR body: presumably DataTables 3 no longer picks up our global $.ajaxSetup() now that jQuery is optional for it. Without that, the next person rediscovers it.

Two things follow. It is ten copies of the same line - one definition in utils.js would do, and it avoids a const csrfToken collision should two of these scripts ever share a page.

And it was only added to the ajax blocks, which are all GETs. If $.ajaxSetup() is dead here, our POST/PUT/DELETE calls are the ones to worry about. Worth confirming before this lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants