Update jquery to v4.0.0 - #3842
Conversation
Signed-off-by: yubiuser <github@yubiuser.dev>
|
This time, it will break with the completely outdated https://github.com/mouse0270/bootstrap-notify because this function was removed https://api.jquery.com/jQuery.isFunction/#jQuery-isFunction-value Maybe we could use Bootstrapv5's toast as a replacement: |
Signed-off-by: yubiuser <github@yubiuser.dev>
|
I let the AI replace the bootstrap-notify with bootstrap-toast and it worked quite well. Needs some tweaking of the design, but works as intended. ADD Continues here: #3843 as it is independent of |
0e98383 to
bfa9200
Compare
|
I was thinking and I don't see a good reason to migrate to jQuery 4:
My suggestion is: Let's finish the plugins migration (including datatables, notify and maybe others), but without jQuery 4. Then, we focus on things we need to finish release the new web interface, like adjusting all themes. What do you think? |
What does this PR aim to accomplish?:
Feeling brave today. After AdminLTE4 and Datatables don't depend on jquery anymore, I thought I give it a try. Also,
bootstrap-selectis gone (see here), which was a blocker before.By submitting this pull request, I confirm the following:
git rebase)