Skip to content

Update jquery to v4.0.0 - #3842

Draft
yubiuser wants to merge 2 commits into
update/datatablesfrom
update/jquery
Draft

Update jquery to v4.0.0#3842
yubiuser wants to merge 2 commits into
update/datatablesfrom
update/jquery

Conversation

@yubiuser

@yubiuser yubiuser commented Aug 6, 2026

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

Feeling brave today. After AdminLTE4 and Datatables don't depend on jquery anymore, I thought I give it a try. Also, bootstrap-select is gone (see here), which was a blocker before.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser

yubiuser commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

This time, it will break with the completely outdated https://github.com/mouse0270/bootstrap-notify because this function was removed https://api.jquery.com/jQuery.isFunction/#jQuery-isFunction-value

Maybe we could use Bootstrapv5's toast as a replacement:
https://getbootstrap.com/docs/5.0/components/toasts/

Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser

yubiuser commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

I let the AI replace the bootstrap-notify with bootstrap-toast and it worked quite well. Needs some tweaking of the design, but works as intended.

ADD

Continues here: #3843 as it is independent of jquery.

@yubiuser
yubiuser force-pushed the update/jquery branch 2 times, most recently from 0e98383 to bfa9200 Compare August 6, 2026 16:27
@rdwebdesign

Copy link
Copy Markdown
Member

@yubiuser,

I was thinking and I don't see a good reason to migrate to jQuery 4:

  • All current plugins work with jQuery 3.

  • Bootstrap 5 and AdmiLTE v4 doesn't need jQuery at all:
    we can use any jQuery version, or not use it.

  • Datatables 3.0.1 doesn't require jQuery:
    In this case, I think we should use jQuery to keep the current code, just to avoid rewriting all datatables code. We can use jQuery 3.

  • jQuery 4 removes support for some older browsers.
    I'm not sure how many users are still using older browsers, but there are probably a few ones that will complain.

My suggestion is:

Let's finish the plugins migration (including datatables, notify and maybe others), but without jQuery 4.

Then, we focus on things we need to finish release the new web interface, like adjusting all themes.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants